ElectricTariff big-M updates for demand and energy tiers #513
Conversation
| added_power = !isempty(p.s.storage.types.elec) ? sum(p.s.storage.attr[b].max_kw for b in p.s.storage.types.elec) : 1.0e-3 | ||
|
|
||
| electric_demand_bigM = 2 * maximum(100*p.s.electric_load.loads_kw .+ | ||
| p.s.space_heating_load.loads_kw .+ |
There was a problem hiding this comment.
Are these heating and cooling loads in here because we might be converting them to electric loads with a COP as low as 1?
There was a problem hiding this comment.
it's a COP as low as 0.5, in part because of low-COP techs like an ASHP under low temperature. I added a few notes here: 5fa0412 (lines 467-468)
| #big-M used for monthly demand tiers | ||
| added_power = !isempty(p.s.storage.types.elec) ? sum(p.s.storage.attr[b].max_kw for b in p.s.storage.types.elec) : 1.0e-3 | ||
|
|
||
| electric_demand_bigM = 2 * maximum(100*p.s.electric_load.loads_kw .+ |
There was a problem hiding this comment.
Why 100x the electric load, and then 2x the max of the load aggregation here?
There was a problem hiding this comment.
This was an assumption from the "legacy" code in reo/ - we adopted it for use as an upper bound when charging seasonal storage systems.
| b = m[Symbol(dv)] | ||
|
|
||
|
|
||
| # Implement Big-M constratint for TOU demand tiers |
There was a problem hiding this comment.
Optional request: this code block looks very similar to the one above, so it would be helpful and DRY to make a function which could then be used by either of these functions with the different arguments. If that's more challenging than I'm thinking it would be, feel free to keep as is.
There was a problem hiding this comment.
agreed, great catch! addressed here, and marking the other related comment as resolved since it's related to this thread: 5fa0412
|
Ready for your re-review @Bill-Becker! |
2 participants
Fixed
Addresses issue #410
The newly added tests failed with the previous implementation.