Skip to content

compare debug-ghp-3 and remove-ghp-updates #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 106 commits into
base: debug-ghp-3
Choose a base branch
from
Draft

compare debug-ghp-3 and remove-ghp-updates #520

wants to merge 106 commits into from

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented Oct 2, 2025

No description provided.

lixiangk1 and others added 30 commits December 2, 2024 15:16
@lixiangk1
Allow user to specify if the auxiliary unit is heating or cooling for…
b584149 
… hybrid GHP
@lixiangk1
Update nomenclature
971b3e7
@lixiangk1
Update changelog
2fe80fa
@atpham88
Merge branch 'develop' into ghp-select-hybrid-aux-unit
7366f99
@lixiangk1
Update hybrid GHP runs to try to always return a hybrid result
f99997b
@atpham88
Merge branch 'develop' into ghp-select-hybrid-aux-unit
bf6bb23
@lixiangk1
Add output for ghpghx solve time
228ad0e
@lixiangk1
round ghp_option_chosen
3c49a86
@lixiangk1
Fixed syntax error
902e999
@lixiangk1
fix ghp results rounding
67d9ff9
@lixiangk1
Test flipped guess for hybrid GHP
2968682
@lixiangk1
Merge branch 'develop' into ghp-select-hybrid-aux-unit
d14abfd
@lixiangk1
Prioritize hybrid GHP over pre-sized GHP/GHX limits
19429d8
@lixiangk1
Merge branch 'develop' into ghp-select-hybrid-aux-unit
8fd12d9
@lixiangk1
Revert to original automatic hybrid sizing guess
f2b9354
@Bill-Becker
Merge pull request #510 from NREL/develop
cfbd74b 
v0.54.0 master < develop
@Bill-Becker
Sum CHP/Boiler to Hot + High TES for thermal_to_storage
fc3544b
@lixiangk1
Rename test_hybrid_case to hybrid_solution_type
9b9995b
@lixiangk1
Add hybrid GHP test that does not use ghpghx_responses
344dd8f
@lixiangk1
Increase tolerance on hybrid test
1f65aa5
@lixiangk1
Update hybrid test variable name to avoid impacting other tests
03bf61a
@Bill-Becker
Change hot storage index to be consistent with others
1627ac9
@Bill-Becker
Update CHANGELOG for fix
becf1cc
@Bill-Becker
Merge pull request #514 from NREL/fix-tes-results
e96a7fb 
Fix error with CHP + HighTempThermalStorage
@zolanaj
rm CST from forced zero-waste techs
2ef5185
@zolanaj
add attribute can_waste_heat to CST tech (default=true)
794710c
@zolanaj
force zero waste heat if CST.can_waste_heat == false
ff77aac
@zolanaj
update CST docstrings
a6f0e5b
@zolanaj
update CST test with large enough system to curtail
48e1aaf
@zolanaj
ix format of CST curtailed test
0529da8
hdunham and others added 30 commits September 30, 2025 19:20
@hdunham
update REopt version num
acf8906
@hdunham
Merge branch 'master' into develop
f71279f
@hdunham
Update CHANGELOG.md
61680f8
@hdunham
Update CHANGELOG.md
69b7017
@hdunham
Revert "Remove old comments"
1843421 
This reverts commit 8eb7761.
@hdunham
Revert "Update hybrid test variable name to avoid impacting other tests"
aaa6ebe 
This reverts commit 03bf61a.
@hdunham
Revert "Increase tolerance on hybrid test"
af8eb2f 
This reverts commit 1f65aa5.
@hdunham
Revert "Add hybrid GHP test that does not use ghpghx_responses"
63b8f3e 
This reverts commit 344dd8f.
@hdunham
Revert "Rename test_hybrid_case to hybrid_solution_type"
5f19ef1 
This reverts commit 9b9995b.
@hdunham
Revert "Revert to original automatic hybrid sizing guess"
2a6752f 
This reverts commit f2b9354.
@hdunham
Revert "Prioritize hybrid GHP over pre-sized GHP/GHX limits"
bd3fb90 
This reverts commit 19429d8.
@hdunham
Revert "Test flipped guess for hybrid GHP"
9dff649 
This reverts commit 2968682.
@hdunham
Revert "fix ghp results rounding"
1107124 
This reverts commit 67d9ff9.
@hdunham
Revert "Fixed syntax error"
6b8239e 
This reverts commit 902e999.
@hdunham
Revert "round ghp_option_chosen"
dcca2cc 
This reverts commit 3c49a86.
@hdunham
Revert "Add output for ghpghx solve time"
f4b65d2 
This reverts commit 228ad0e.
@hdunham
Revert "Update hybrid GHP runs to try to always return a hybrid result"
6ea9e94 
This reverts commit f99997b.
@hdunham
manually revert 2fe80fa
0c8eaf2
@hdunham
Revert "Update nomenclature"
591d7f7 
This reverts commit 971b3e7.
@hdunham
Revert "Allow user to specify if the auxiliary unit is heating or coo…
3ebd56e 
…ling for hybrid GHP"

This reverts commit b584149.
@hdunham
Revert "Update CHANGELOG.md"
cdbed54 
This reverts commit 69b7017.
@hdunham @Copilot
round GHPOptionChosen
2094c09 
Co-authored-by: Copilot <[email protected]>
@hdunham @Copilot
incorrect backslash usage
4d5f181 
Co-authored-by: Copilot <[email protected]>
@hdunham
fix version number to align with develop
910f39e
@hdunham
fix merge mistake while reverting
edbb482
@hdunham
comment tests to test faster
b9ba9b9
@hdunham
missing end and dupe code
c712c39
@hdunham
uncomment tests
5de8da5
@hdunham
rm commented code
77f2837
@hdunham
Merge branch 'debug-ghp-3' into remove-ghp-updates
8595ad7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hdunham @JuliaRegistrator @Bill-Becker @lixiangk1 @atpham88 @zolanaj