-
Notifications
You must be signed in to change notification settings - Fork 195
Update Solar Resource UI forms for solar techs #2120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Break Solar Resource Download form into three separate forms to simplify troubleshooting of UI callbacks: * Solar Resource Download * Solar Resource Information * Solar Resource Library Initial testing for PVWatts only.
* Add show log button (instead of automatically showing it after file downloads) * Realign widgets and edit labels
… in decimal degrees" default
* Improve identification of lat/lon pair as input * Remove location string from file name to avoid wfcheck failure when string contains some unicode characters, e.g., cyrillic.
Solar Resource Data broken down into three forms: * Solar Resource Download * Solar Resource Library * Solar Resource Information
No longer needed now that `use_specific_weather_file` is available to user on Solar Resource Library form.
Note `solar_data_file_name_load` variable removed from defaults in commit bd9fda4.
Remove commented-out code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjanzou I put the Download button at the top to emphasize the most common workflow, which is to type an address and click Download. The stuff under the Options line is optional. I don't think there is an ideal layout that is best for all users, so this is a compromise. We have three workflows, and don't know of a great way to communicate that clearly: 1) Type an address and click Download, 2) Type and address, choose options, and click Download, and 3) Choose the Advanced option, click Download, and choose options in the Advanced NSRDB window. |
I created an issue for this: #2122 |
Description
Redesign Solar Resource UI form to simplify debugging:
solar_data_file_name_load
variable.Update geocode function in geotools.cpp
Fixes #1426
Corresponding branches and PRs:
Goes with Develop branches of SAM-private, SSC, WEX, and LK.
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)