Skip to content

Conversation

cpaulgilman
Copy link
Collaborator

@cpaulgilman cpaulgilman commented Oct 1, 2025

Description

Redesign Solar Resource UI form to simplify debugging:

  • Break up Solar Resource Downloads into three forms: Solar Resource Download, Solar Resource Library, and Solar Resource Information.
  • Rewrite UI callback functions to minimize repeated calls to functions.
  • Expose user-specified weather file option to avoid need for confusing weather file checks and remove solar_data_file_name_load variable.

Update geocode function in geotools.cpp

  • Handle unicode location names including Cyrillic characters and prime and double-prime characters in coordinates.
  • Separate geocoding and time zone functions.

Fixes #1426

Corresponding branches and PRs:

Goes with Develop branches of SAM-private, SSC, WEX, and LK.

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

Break Solar Resource Download form into three separate forms to simplify troubleshooting of UI callbacks:

* Solar Resource Download
* Solar Resource Information
* Solar Resource Library

Initial testing for PVWatts only.
* Add show log button (instead of automatically showing it after file downloads)
* Realign widgets and edit labels
* Improve identification of lat/lon pair as input
* Remove location string from file name to avoid wfcheck failure when string contains some unicode characters, e.g., cyrillic.
@cpaulgilman cpaulgilman added this to the SAM Fall 2025 Release milestone Oct 1, 2025
@cpaulgilman cpaulgilman added the requires help revision Requires a Help revision before releasing public version label Oct 1, 2025
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my tests worked with a couple of comments:

  1. Maybe a little "Download Progress" dialog resizing to show entire "Close" button (Windows 11)
Image
  1. Should the "Download" button be moved down to visually include the "Options" section?
Image

Copy link
Collaborator

@mjprilliman mjprilliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nitpicky but with the new wxWidgets version it seems like the text on some UI objects is not vertically centered. See 'Default TMY file':

image

This is not something that can be changed at the IDE level.

Nothing else to add beyond comments in previous email discussion.

@cpaulgilman
Copy link
Collaborator Author

Should the "Download" button be moved down to visually include the "Options" section?

@sjanzou I put the Download button at the top to emphasize the most common workflow, which is to type an address and click Download. The stuff under the Options line is optional. I don't think there is an ideal layout that is best for all users, so this is a compromise. We have three workflows, and don't know of a great way to communicate that clearly: 1) Type an address and click Download, 2) Type and address, choose options, and click Download, and 3) Choose the Advanced option, click Download, and choose options in the Advanced NSRDB window.

@cpaulgilman
Copy link
Collaborator Author

Maybe a little "Download Progress" dialog resizing to show entire "Close" button (Windows 11)

I created an issue for this: #2122

@cpaulgilman cpaulgilman merged commit 7233d27 into develop Oct 3, 2025
8 checks passed
@cpaulgilman cpaulgilman deleted the sam-1426-parse-lat-lon branch October 3, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires help revision Requires a Help revision before releasing public version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create an error if someone enters Lat/Long pairs with N,s,e,w and show them the proper format.

3 participants