-
Notifications
You must be signed in to change notification settings - Fork 11
Consolidate plotting functions #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r loco type per recommended
… only plot speed limit in SLTS plots
…te is somehow not working, need to take deeper look.
… the structure with pandas dataframes
…Stopping for now to go do a couple other things. There's probably some optimization that needs to occur once I get this working. Black did a whole lot of formatting on this. That is most of the changes.
I'm digging into the rollout demo. I have made progress in getting it to work, but I have run into something that I don't fully understand what is going on in the utilities.py set_param_from_path function. I think I know what is going on, and I think we could maybe simplify this a lot since we're dealing with dictionaries and not objects. Let me know what you think. https://github.com/NREL/altrios/blob/main/python/altrios/utilities.py#L158 |
To duplicate verificiation: - run python/altrios/demos/speed_limit_train_sim_demo_with_derating.py - run ```python to_dataframe = train_sim.to_dataframe()[-1] common_cols = set(train_sim.to_dataframe()[-1].columns) & set(to_dataframe_expected.columns) [col for col in common_cols if not to_dataframe_expected[col].equals(to_dataframe[col])] ``` rollout_demo.py runs but plots need attention
…data that needs to be checked and updated if no errors are found
…idated plot_util.py and import functions accordingly
@calbaker I had some time tonight to dig back into ALTRIOS proper. I ran build and test with pixi on my windows computer. I noticed this note about not find maturin. Everything else seemed to pass. I do have maturin in this environment because I was aable to run "pixi run maturin develop --release" from my command line. Not sure if this concerning or not. Let me know if you have any other specific tasks that I can help with. ![]() |
…expected, after checking
…ios into Consolidate-plotting-functions
Largely synced up with #133, but we for sure need to make sure both get merged into main, to include the following new features:
TrackedState
to ensure that each state variable is updated once and only once in each time step unless we deliberately override that behavior, which is necessary in a few edge casesto_pydict()
andfrom_pydict()
methods instead because these provide a much cleaner user experiencefastsim-3
, making for easier back-and-forth improvements and a platform for eventually transitioning to a common dependency crate for both FASTSim and ALTRIOSTasks before altrios 1.0.0 release
rollout_demo.py
:SpeedLimitTrainSim history doesn't include time and/or speed, so meet pass events cannot be counted. Units of detailed not supported for freight movement calculation.
see message in f0f103e