investigate and maybe fix some unexpected behavior with derating in Hybrid #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but it's acting a bit weirdly for the hybrid locomotive, which needs further investigation
calbaker
commented
May 22, 2025
| [hel.clone()] | ||
| + [alt.Locomotive.default()] * 1 | ||
| [alt.Locomotive.default()] * 2 | ||
| # + [hel.clone()] |
There was a problem hiding this comment.
@FDsteven uncomment this
calbaker
commented
May 22, 2025
|
|
||
| fc_with_derate = alt.FuelConverter.default() | ||
| fc_with_derate.set_default_elev_and_temp_derate() | ||
| fc_with_derate_dict = fc_with_derate.to_pydict() |
There was a problem hiding this comment.
@FDsteven this fc_with_derate_dict is the conventional FC. We need to make an equivalent for the hybrid and set the derate on it instead!
- get the HEL dict
- pull the FC out
- instantiate a new FC for the HEL
- run the
set_...deratemethod - turn it back into a dict
- put in the HEL dict
- turn the HEL dict back into a HEL
calbaker
commented
May 22, 2025
| df_with_derate['history.time_seconds'], | ||
| df_with_derate['loco_con.history.energy_fuel_joules'] / 1e9, | ||
| label='with derate', | ||
| label='with derate',u |
There was a problem hiding this comment.
- remove the
,uat the end of this line, d'oh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
but it's acting a bit weirdly for the hybrid locomotive, which needs further investigation
Solution