-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eddy viscosity wake model #882
Draft
misi9170
wants to merge
73
commits into
NREL:develop
Choose a base branch
from
misi9170:feature/ev-model
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,832
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts needed to be bumped up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
examples
Changes to FLORIS examples
floris.simulation
in-progress
Work is actively in progress
new-feature
A new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eddy viscosity wake model
Introduces the eddy viscosity wake model, as described by Ainslie (1988) and extended by Gunn (2019).
The implementation comprises the following:
These are implemented in the following locations:
streamtube_expansion_solver()
andfull_flow_streamtube_expansion_solver()
)This pull request is currently a draft, while we work through final implementation steps and incorporate feedback.
TODO
Include wake deflection model(currently raisesNotImplementedError
with nonzero yaw angles)