Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Wind Rose Plot (v2) #969

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Improved Wind Rose Plot (v2) #969

merged 5 commits into from
Sep 16, 2024

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Aug 22, 2024

Improved Wind Rose Plot v2

This is a reimplementation of the code changes proposed by @cfrontin in #968 but built on the develop branch instead of main (something about running that way is triggering some errors, and anyway breaks our convention). Running for example the wind_data_user notebook changes the look of wind rose plots from:

image

To:

image

Which is an improvement to my eye. Thanks @cfrontin for the submission!

Related issue

#968

Impacted areas of the software

wind_data.py

@paulf81 paulf81 added the enhancement An improvement of an existing feature label Aug 22, 2024
@paulf81 paulf81 self-assigned this Aug 22, 2024
@paulf81 paulf81 changed the base branch from main to develop August 22, 2024 04:02
@paulf81
Copy link
Collaborator Author

paulf81 commented Aug 22, 2024

If we make this change here should also consider WindTIRose

@paulf81 paulf81 mentioned this pull request Aug 22, 2024
floris/wind_data.py Outdated Show resolved Hide resolved
@misi9170
Copy link
Collaborator

misi9170 commented Sep 16, 2024

Note that merging this PR could potentially introduce a breaking change for a very small number of users. The ax returned by the plot() method will now no longer contain a legend (and instead a colorbar). Any code that subsequently obtains and modifies the properties of the legend will no longer work.

While this is indeed a breaking change, and therefore against the rules of semantic versioning that we try to adhere to with FLORIS, we feel that this is a small enough change that it will affect very few (and quite possibly no) users, and are going to proceed to merge under the same major version of FLORIS (v4).

If this change affects you negatively, please let us know by commenting on this PR and we will search for a resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants