-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Wind Rose Plot (v2) #969
Conversation
If we make this change here should also consider WindTIRose |
Note that merging this PR could potentially introduce a breaking change for a very small number of users. The While this is indeed a breaking change, and therefore against the rules of semantic versioning that we try to adhere to with FLORIS, we feel that this is a small enough change that it will affect very few (and quite possibly no) users, and are going to proceed to merge under the same major version of FLORIS (v4). If this change affects you negatively, please let us know by commenting on this PR and we will search for a resolution. |
Improved Wind Rose Plot v2
This is a reimplementation of the code changes proposed by @cfrontin in #968 but built on the develop branch instead of main (something about running that way is triggering some errors, and anyway breaks our convention). Running for example the wind_data_user notebook changes the look of wind rose plots from:
To:
Which is an improvement to my eye. Thanks @cfrontin for the submission!
Related issue
#968
Impacted areas of the software
wind_data.py