-
Notifications
You must be signed in to change notification settings - Fork 177
[BUGFIX] Improve handling of multidimensional turbine conditions #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
I'm now done with code changes (I think), but starting to work on the docs I think this is a good time to go ahead and improve turbine documentation across the board. I plan to add a Turbine "subfolder" to the documentation, and in it place (while reworking):
|
After discussing with @dzalkind , I've decided that in this PR, I will include the bug fix for specifying multidimensional input conditions but not yet update reference values for the floating IEA 15MW turbine. In the mean time, I have updated various pieces of the documentation for floating turbines and indicated that the floating tilt table, along with the dependency of the thrust coefficient and power curves on wave height and wave period, should be treated as fictional. I will indicate this decision in related issues and discussions. |
7dd8f2f
to
c46c005
Compare
@@ -89,7 +89,7 @@ | |||
tilt_angles_floating_defined_floating, | |||
color="m", | |||
ls="--", | |||
label="Floating (cp/ct not scaled by tilt)", | |||
label="Floating (power/thrust coefficient not scaled by tilt)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a prior issue, but shouldn't the magenta dashed line be on top of the blue line in the 0th axis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is currently correct. The idea here is that the black line represents the fixed-bottom NREL 5MW; the blue line represents what happens if you took the fixed NREL 5MW and put it on a floater (with a fictional level of added tilt for different wind speeds); and the magenta dashed line is the (fictional) case where the NREL 5MW power and thrust coefficient is defined as being on a floating platform, so no tilt correction to the power and thrust curve should be applied (as the effect of tilt is already inherently included).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed and ran the tests and went through and ran all examples. I reviewed all the code and docs and all looks good to me. Left a few minor comments
This pull request provides various bug fixes to the multidimensional turbine code. In particular, it allows users to specify the
multidim_conditions
as a keyword argument toFlorisModel.set()
. Additional bug fixes include the ability to use a single condition and updates to the multidimensional turbine documentation (and turbine documentation more broadly).Related issues:
turbulence_intensities
keyword argument inFlorisModel.set()
will still not access the multidimensional code; users will need to specify turbulence intensity separately in themultidim_conditions
. This is as far as we will go with this, and I will consider the issue addressed. See Complete multi-dim code #989 for more discussion.TurbineInterface
andTurbineLibrary
from documentation and added deprecation warnings to these classes.Related PRs:
Not addressed here
Values given for the IEA 15MW reference turbine for the floating tilt angle and dependency of power and thurst on wave height, wave period, and turbulence intensity are fictional and may be misleading. I intend to open a separate issue to address this in future.
To do