Skip to content

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Oct 9, 2024

This pull request provides various bug fixes to the multidimensional turbine code. In particular, it allows users to specify the multidim_conditions as a keyword argument to FlorisModel.set(). Additional bug fixes include the ability to use a single condition and updates to the multidimensional turbine documentation (and turbine documentation more broadly).

Related issues:

Related PRs:

Not addressed here

Values given for the IEA 15MW reference turbine for the floating tilt angle and dependency of power and thurst on wave height, wave period, and turbulence intensity are fictional and may be misleading. I intend to open a separate issue to address this in future.

To do

  • existing tests pass (in particular, turbine_multi_dim_unit_test.py)
  • add new tests for multidim turbine code
  • documentation for multidim
  • Fill in PR description
  • Update turbine library documentation

@misi9170 misi9170 mentioned this pull request Oct 9, 2024
6 tasks
@misi9170
Copy link
Collaborator Author

misi9170 commented Aug 27, 2025

I'm now done with code changes (I think), but starting to work on the docs I think this is a good time to go ahead and improve turbine documentation across the board. I plan to add a Turbine "subfolder" to the documentation, and in it place (while reworking):

@misi9170
Copy link
Collaborator Author

After discussing with @dzalkind , I've decided that in this PR, I will include the bug fix for specifying multidimensional input conditions but not yet update reference values for the floating IEA 15MW turbine. In the mean time, I have updated various pieces of the documentation for floating turbines and indicated that the floating tilt table, along with the dependency of the thrust coefficient and power curves on wave height and wave period, should be treated as fictional. I will indicate this decision in related issues and discussions.

@misi9170 misi9170 marked this pull request as ready for review September 15, 2025 23:03
@paulf81 paulf81 self-requested a review September 16, 2025 02:30
@@ -89,7 +89,7 @@
tilt_angles_floating_defined_floating,
color="m",
ls="--",
label="Floating (cp/ct not scaled by tilt)",
label="Floating (power/thrust coefficient not scaled by tilt)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a prior issue, but shouldn't the magenta dashed line be on top of the blue line in the 0th axis?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is currently correct. The idea here is that the black line represents the fixed-bottom NREL 5MW; the blue line represents what happens if you took the fixed NREL 5MW and put it on a floater (with a fictional level of added tilt for different wind speeds); and the magenta dashed line is the (fictional) case where the NREL 5MW power and thrust coefficient is defined as being on a floating platform, so no tilt correction to the power and thrust curve should be applied (as the effect of tilt is already inherently included).

Copy link
Collaborator

@paulf81 paulf81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed and ran the tests and went through and ran all examples. I reviewed all the code and docs and all looks good to me. Left a few minor comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants