Nrcan 404 all #1990
Open
Nrcan 404 all #1990
+1,284,237
−10,589,367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furnace unit tests updated to new format
|
@ckirney don't merge this yet. We made a change to the naming of HVAC loops that is impacting the regression testing. Hopefully will have the updates next week. |
(nrcan at 792ffd6; 3.9.0)
… tests need fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
Updates failing tests to use new methods, e.g. setting fuel type in Standards class
Corrects logic in 'convert_arg_to_XXX' methods in nrcb_2011.rb (convert to bool was not working as intended)
Updates reference values specified in NECB and adds references to the code (sections, table numbers and page if required)
Fixes kBTU bug in DX heating coil single speed
Adds references to source papers in service water heating code (NECB 2020)
Fixes issue with naming in NECB hvac_systems (ERV's were being incorrectly labeled)
Reverted TBD code to old failing method call (as per discussion with DB)
Review Checklist
All NECB unit tests (except TBD) are now passing.