Skip to content

Conversation

mcllerena
Copy link
Contributor

No description provided.

@mcllerena mcllerena requested review from Copilot and pesap and removed request for Copilot October 13, 2025 00:57
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.76%. Comparing base (2f5f407) to head (586acee).

Files with missing lines Patch % Lines
src/r2x_core/processors.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   97.94%   97.76%   -0.19%     
==========================================
  Files          19       19              
  Lines        1024     1029       +5     
==========================================
+ Hits         1003     1006       +3     
- Misses         21       23       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 01:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a pivot functionality to handle modeledyears files by introducing a new transformation step in the tabular data processing pipeline.

  • Added pl_pivot_on function to perform DataFrame pivoting based on configuration
  • Integrated the pivot function into the existing transformation pipeline
  • The function unpivots all columns and selects only the specified pivot column

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

if not data_file.pivot_on:
return df

all_columns = df.collect_schema().names()
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling collect_schema() forces schema collection which can be expensive for large lazy frames. Consider using df.schema.names() or df.columns if available in the Polars version being used.

Suggested change
all_columns = df.collect_schema().names()
all_columns = df.columns

Copilot uses AI. Check for mistakes.

Copy link
Collaborator

@pesap pesap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcllerena , can you add notes using numpy style on why we do this? Also, i think we have on the docstring on the pipeline the process, can you update the docstring as well?

@mcllerena mcllerena requested a review from pesap October 13, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants