Skip to content

Conversation

mcllerena
Copy link
Contributor

No description provided.

@mcllerena mcllerena requested review from Copilot and pesap and removed request for Copilot October 13, 2025 01:00
@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 01:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the handling of modeled years data to standardize its naming and improve data structure parsing. The changes address inconsistencies between file mapping configuration and parser logic for accessing modeled years information.

  • Updates file mapping from "modeledyears" to "modeled_years" for consistency
  • Modifies parser to access modeled years data as a proper column instead of row-based access
  • Adds schema and pivot configuration for better data structure handling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/r2x_reeds/parser.py Updates variable references and data access pattern for modeled years
src/r2x_reeds/config/file_mapping.json Renames mapping from "modeledyears" to "modeled_years" and adds schema configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mcllerena
Copy link
Contributor Author

It is failing 'cause it's depending on ml/create-pivot-func branch in r2x-core (already in PR)

@mcllerena mcllerena merged commit db8c471 into main Oct 13, 2025
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants