Refactoring Simulation concept

[castelao]

Refactoring the full crate concept model to help isolating components thus isolating major refactoring in smaller parts.

[Copilot]

Pull Request Overview

This PR refactors the simulation concept by extracting the Simulation struct and related logic into a dedicated module to improve code organization and component isolation.

• Moves the Simulation struct and related functionality from lib.rs to a new simulation/mod.rs module
• Introduces new internal structs (Scenario, Solution, Features, Algorithm) to better organize simulation components
• Updates the public API to use a compute() method that returns an iterator instead of scout() that returns a Vec

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
crates/revrt/src/simulation/mod.rs	New module containing the refactored Simulation struct with improved component separation
crates/revrt/src/lib.rs	Removes Simulation implementation and imports it from the new simulation module
crates/revrt/src/cost.rs	Adds Clone trait to CostFunction to support the refactored design

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[ppinchuk]

As long as you're going through the effort of refactoring and re-organizing, do we think that "Simulation" is the right term? We're not really simulating anything, right? It's more like a "computation" or something along those lines.

Nitpicky but this is the kind of PR where we can think about those things IMO

[castelao]

As long as you're going through the effort of refactoring and re-organizing, do we think that "Simulation" is the right term? We're not really simulating anything, right? It's more like a "computation" or something along those lines.

Nitpicky but this is the kind of PR where we can think about those things IMO

I'm not super happy with Simulation, but I can't figure out a good name. The other alternative was CaseStudy.

Whatever name it is, it's state is defined by the composition of Scenario + Algorithm + Config. The Config defines if runs concurrently, how many concurrent solutions, preserve cost surface or use a temp, ... Then we can call Simulation.compute(BoundaryConditions). BTW, I'm looking for a replace name for BoundaryConditions since most people will make a confusion with the boundaries of the GIS input features. Any suggestions @ppinchuk ?

[Copilot]

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (3)

crates/revrt/src/lib.rs:171

• The method scout does not exist on Routing. Should use compute(...).collect() to match the new API.

        let solutions = simulation.scout(&start, end);

crates/revrt/src/lib.rs:171

• The method scout does not exist on Routing. Should use compute(...).collect() to match the new API.

        let solutions = simulation.scout(&start, end);

crates/revrt/src/lib.rs:233

• The method scout does not exist on Routing. Should use compute(...).collect() to match the new API.

        let solutions = simulation.scout(&start, end);

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}