Skip to content

Conversation

castelao
Copy link
Member

@castelao castelao commented Oct 7, 2025

Track effect of efficient concurrency. Multiple routes on the same area should benefit from reusing cost.

Verify efficiency of running multiple rountes over the same region, thus
hwne it is possible to re-use estimated costs.
@castelao castelao self-assigned this Oct 7, 2025
@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 23:51
@castelao castelao requested a review from ppinchuk as a code owner October 7, 2025 23:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a benchmark to test the efficiency of computing multiple routes in the same area, measuring how well the routing algorithm can reuse cost calculations across overlapping paths.

  • Adds a new multiple_routes benchmark function that tests pathfinding for 15 closely positioned start points to a single destination
  • Integrates the new benchmark into the existing benchmark suite

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@castelao castelao added chore Maintenance work that does not impact the end user p-low Priority: low rust labels Oct 7, 2025
ppinchuk
ppinchuk previously approved these changes Oct 7, 2025
Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooo yea I would be curious to monitor this one!

ppinchuk
ppinchuk previously approved these changes Oct 8, 2025
@ppinchuk ppinchuk added topic-rust-general Issues/pull requests related to rust and removed rust labels Oct 8, 2025
@ppinchuk
Copy link
Collaborator

ppinchuk commented Oct 8, 2025

Side note, let's use topic-rust-general instead of the rust label. The former is a bit more descriptive and we can add more versions of it as needed

@ppinchuk ppinchuk added this to the Finalize OSS release milestone Oct 8, 2025
Those two cases monitor for different things. Nearby routes evaluate how
we re-use the cost field, while the nearby evaluate how we handle I/O
accessing different chunks.
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@castelao castelao merged commit b9f550b into main Oct 8, 2025
18 checks passed
@castelao castelao deleted the bench_multiple branch October 8, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance work that does not impact the end user p-low Priority: low topic-rust-general Issues/pull requests related to rust

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants