fix: Temporarily increasing benchmark tolerance #157
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the update to Zarr-0.22, I had to temporarily switch off the use of the cache layer for cost access, thus increasing the times. I'm increasing the benchmark tolerance for warning to allow moving on. The full features and cost access are in the process of refactoring.
There was a problem hiding this comment.
Pull Request Overview
Temporarily relaxes benchmark regression alert sensitivity to accommodate slower runs after disabling the cache layer during the Zarr 0.22 upgrade/refactor.
- Increase benchmark alert threshold from 150% to 250% to reduce noise during ongoing refactoring.
- No code logic changes; only CI workflow configuration adjustment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the update to Zarr-0.22, I had to temporarily switch off the use of the cache layer for cost access, thus increasing the times. I'm increasing the benchmark tolerance for warning to allow moving on. The full features and cost access are in the process of refactoring.