Skip to content

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Jun 1, 2025

Set up GHA for Python linting and testing

@ppinchuk ppinchuk self-assigned this Jun 1, 2025
@ppinchuk ppinchuk added the chore Maintenance work that does not impact the end user label Jun 1, 2025
@ppinchuk ppinchuk marked this pull request as ready for review June 2, 2025 02:54
@ppinchuk ppinchuk requested a review from castelao June 2, 2025 02:57
@ppinchuk ppinchuk linked an issue Jun 2, 2025 that may be closed by this pull request
@ppinchuk
Copy link
Collaborator Author

ppinchuk commented Jun 2, 2025

@castelao I haven't set up tox before, so a second set of eyes on this would be super helpful. Anything you think I should change?

@castelao
Copy link
Member

castelao commented Jun 2, 2025

It looks like it is failing only on windows due to GAPs? import pwd?

@ppinchuk
Copy link
Collaborator Author

ppinchuk commented Jun 2, 2025

It looks like it is failing only on windows due to GAPs? import pwd?

yup, I was already working on that fix

@ppinchuk
Copy link
Collaborator Author

ppinchuk commented Jun 2, 2025

I know how to fix the last tests but it's late so i will leave it for tomorrow

@ppinchuk
Copy link
Collaborator Author

@castelao This is ready for review

Copy link
Member

@castelao castelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppinchuk ppinchuk merged commit eb6b72e into main Jun 18, 2025
22 checks passed
@ppinchuk ppinchuk deleted the pp/add_tox branch June 18, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance work that does not impact the end user

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up Python tests GHA

2 participants