Skip to content

Delta cost #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Delta cost #96

wants to merge 25 commits into from

Conversation

castelao
Copy link
Member

No description provided.

@castelao castelao self-assigned this Aug 20, 2025
@ppinchuk ppinchuk added enhancement Update to logic or general code improvements p-critical Priority: critical topic-rust-routing Issues/pull requests related to rust routing code labels Aug 21, 2025
@castelao
Copy link
Member Author

castelao commented Sep 5, 2025

This PR was getting too large and mixing multiple goals. I'm extracting some parts and moving to main in multiple PRs with well defined scopes.

@castelao castelao mentioned this pull request Sep 5, 2025
Merged
@castelao
log: Won't be only temporary swap
87f654d
@castelao
refact: Renaming calculate to compute()
6e46ff7
@castelao
refact: Renaming Dataset::open() to new()
2f86a50
@castelao
refact: Moving LazyChunk to its own sub-module
549a554
@castelao
refact: Renaming array to cost to avoid confusion
ab550f0
@castelao
Use expect instead of unwrap
956b3bd
@castelao
feat: Creating empty delta
6cc883d
@castelao
feat: Adding dims in the Dataset struct
74a14c3 
The max i & j are used too often. Better have them ready.
@castelao
test: Check during test that input isn't zero dimension
1c7292a
@castelao
Loading ArraySubset
39af81c
@castelao
fix: Missing CHUNK_SHAPE
1289b6b
@castelao
feat: LazyArray
61481e9 
Decoupling source chunk from the intended output. This allows freedom
between the chunk grid of the source vs the cost.
@castelao
refact: renaming
c27aea9
@castelao
feat: Minimalist Display for LazyDataset
e03c7c5
@castelao
refact: cost.compute now uses LazyDataset
e721507
@castelao
log: Updating, LazyDataset shows subset instead of chunk
45817ea
@castelao
log: LazyDataset loading new variable
7b2e0ba
@castelao
clean:
b28f136
@castelao
clean:
1fc97f5
@castelao
test, fix: It was failing with an empty subset
a06f1bb 
I'll address that in the future. For now, let's test with valid ranges.
@castelao
clean, log: Redundant log
08261aa
@castelao
fix: LazyDataset pub for crate
8eac026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppinchuk ppinchuk Awaiting requested review from ppinchuk ppinchuk will be requested when the pull request is marked ready for review ppinchuk is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@castelao castelao

Labels

enhancement Update to logic or general code improvements p-critical Priority: critical topic-rust-routing Issues/pull requests related to rust routing code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@castelao @ppinchuk