Add two new sco2 configurations#1353
Conversation
…to launch htr bypass for debugging
…to work with Python script
…nger design calculations. Complete finalize_design function
…le optimizer, accounting for missed target outlet temperatures. Fix bug when recompression fraction == 0. Add debug output function.
…or running 2020 Alfani case. Add Bypass Heat Exchanger class.
…outlet) and add HTF PHX outlet output variable.
…riables. Fix bug in csp_common with htr bypass cycle
This reverts commit b04ddf0.
|
TODO: Update documentation https://github.com/NREL/SAM/blob/develop/samples/CSP/sco2_analysis_python_V2/example/User_Guide.pdf |
Pull Request Test Coverage Report for Build 18385148713Details
💛 - Coveralls |
|
Linked to PR https://github.com/NREL/SAM/pull/2118 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds two new sCO2 configurations to the sCO2 design point models: recompression with HTR bypass and turbine split flow cycles. The changes include new cycle classes, supporting methods, and comprehensive unit tests.
- New HTR bypass and turbine split flow cycle configurations with optimization capabilities
- Enhanced cycle error handling and thermal efficiency threshold features
- Updated cost calculations with inflation factors and improved temperature-dependent costing
- Comprehensive unit tests for design point validation of all configurations
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/ssc_test/cmod_sco2_csp_system_test.cpp | Added unit tests for all sCO2 configurations and helper functions |
| tcs/sco2_htrbypass_cycle.h/.cpp | New HTR bypass cycle class with nested optimization architecture |
| tcs/sco2_turbinesplitflow_cycle.h/.cpp | New turbine split flow cycle class with secondary turbine support |
| tcs/sco2_pc_csp_int.h/.cpp | Enhanced interface to support new configurations and improved error handling |
| tcs/sco2_recompression_cycle.h/.cpp | Updated constructors and improved error handling with eta threshold |
| tcs/sco2_partialcooling_cycle.h/.cpp | Updated constructors and improved error handling with eta threshold |
| tcs/sco2_cycle_templates.h | Added new state point enums and error handling framework |
| tcs/sco2_cycle_components.h/.cpp | Enhanced cost calculations with inflation factors |
| tcs/heat_exchangers.h/.cpp | Updated to include inflation year parameter in cost calculations |
| tcs/CMakeLists.txt | Added new source files to build configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Update changelog tags when merged into develop. https://github.com/NREL/SAM/blob/sco2_py_samples/samples/CSP/sco2_analysis_python_V2/changelog.md |
Description
Add recompression with htr bypass and turbine split flow cycles to sco2 design point models.
Corresponding branches and PRs:
wex, lk: develop
sam: sco2_py_samples
Unit Test Impact:
Added unit tests to run the design point of each configuration; compares efficiency, HTF outlet temperature, and cycle cost to hardcoded results. One of the tests may take ~30 seconds (can remove if necessary). No change to test_results file.
Checklist