Skip to content

Conversation

taylorbrown75
Copy link
Collaborator

@taylorbrown75 taylorbrown75 commented Sep 29, 2025

Description

Add recompression with htr bypass and turbine split flow cycles to sco2 design point models.

Corresponding branches and PRs:

wex, lk: develop
sam: sco2_py_samples

Unit Test Impact:

Added unit tests to run the design point of each configuration; compares efficiency, HTF outlet temperature, and cycle cost to hardcoded results. One of the tests may take ~30 seconds (can remove if necessary). No change to test_results file.

Checklist

  • adds, removes, modifies, or deletes variables in existing compute modules
  • I've tagged this PR to a milestone

taylorbrown75 and others added 30 commits April 12, 2023 15:34
…nger design calculations. Complete finalize_design function
…le optimizer, accounting for missed target outlet temperatures. Fix bug when recompression fraction == 0. Add debug output function.
…or running 2020 Alfani case. Add Bypass Heat Exchanger class.
…outlet) and add HTF PHX outlet output variable.
…riables. Fix bug in csp_common with htr bypass cycle
@taylorbrown75 taylorbrown75 added this to the SAM Fall 2025 Release milestone Sep 29, 2025
@taylorbrown75 taylorbrown75 self-assigned this Sep 29, 2025
@taylorbrown75 taylorbrown75 added the csp concentrating solar power label Sep 29, 2025
@taylorbrown75
Copy link
Collaborator Author

@coveralls
Copy link

coveralls commented Sep 29, 2025

Pull Request Test Coverage Report for Build 18385148713

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3013 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.9%) to 57.595%

Files with Coverage Reduction New Missed Lines %
ssc/tcs/sco2_cycle_components.h 1 99.2%
ssc/tcs/sco2_recompression_cycle.h 6 90.06%
ssc/tcs/heat_exchangers.h 10 83.08%
ssc/tcs/sco2_cycle_templates.h 14 90.6%
ssc/tcs/sco2_partialcooling_cycle.h 17 60.4%
ssc/ssc/csp_common.cpp 32 75.67%
ssc/tcs/sco2_pc_csp_int.h 55 54.29%
ssc/ssc/cmod_sco2_csp_system.cpp 200 42.26%
ssc/tcs/sco2_cycle_components.cpp 219 66.33%
ssc/tcs/sco2_recompression_cycle.cpp 340 59.85%
Totals Coverage Status
Change from base Build 18355581094: 0.9%
Covered Lines: 68983
Relevant Lines: 119772

💛 - Coveralls

@taylorbrown75
Copy link
Collaborator Author

@taylorbrown75
Copy link
Collaborator Author

Linked to PR https://github.com/NREL/SAM/pull/2118

@taylorbrown75 taylorbrown75 marked this pull request as ready for review September 30, 2025 20:25
@taylorbrown75 taylorbrown75 requested a review from Copilot October 9, 2025 17:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two new sCO2 configurations to the sCO2 design point models: recompression with HTR bypass and turbine split flow cycles. The changes include new cycle classes, supporting methods, and comprehensive unit tests.

  • New HTR bypass and turbine split flow cycle configurations with optimization capabilities
  • Enhanced cycle error handling and thermal efficiency threshold features
  • Updated cost calculations with inflation factors and improved temperature-dependent costing
  • Comprehensive unit tests for design point validation of all configurations

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/ssc_test/cmod_sco2_csp_system_test.cpp Added unit tests for all sCO2 configurations and helper functions
tcs/sco2_htrbypass_cycle.h/.cpp New HTR bypass cycle class with nested optimization architecture
tcs/sco2_turbinesplitflow_cycle.h/.cpp New turbine split flow cycle class with secondary turbine support
tcs/sco2_pc_csp_int.h/.cpp Enhanced interface to support new configurations and improved error handling
tcs/sco2_recompression_cycle.h/.cpp Updated constructors and improved error handling with eta threshold
tcs/sco2_partialcooling_cycle.h/.cpp Updated constructors and improved error handling with eta threshold
tcs/sco2_cycle_templates.h Added new state point enums and error handling framework
tcs/sco2_cycle_components.h/.cpp Enhanced cost calculations with inflation factors
tcs/heat_exchangers.h/.cpp Updated to include inflation year parameter in cost calculations
tcs/CMakeLists.txt Added new source files to build configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

csp concentrating solar power

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants