Skip to content

Conversation

@prekshivyas
Copy link

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Aims at enhancing auto_configurator by

  1. adding dynamic virtual pipeline parallel size input option
  2. adding possibility to input multiple global batch sizes
  3. adding benchmarking inspired performant settings resulting in dramatic increase in performance
  4. performing parallelism validations
  5. checking if any generated config matches with base config

Collection: [Note which collection this PR will affect]
llm

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

prekshivyas and others added 30 commits June 30, 2025 09:03
Signed-off-by: Prekshi Vyas <[email protected]>
Signed-off-by: Prekshi Vyas <[email protected]>
Signed-off-by: Prekshi Vyas <[email protected]>
Signed-off-by: Prekshi Vyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
prekshivyas and others added 22 commits August 20, 2025 14:08
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
Signed-off-by: prekshivyas <[email protected]>
@prekshivyas prekshivyas changed the title autoconfigurator enhancements done for autotuner autoconfigurator enhancements Aug 22, 2025
if act_layers is not None and act_layers != "auto":
act_ckpt_layers = act_layers
for act in act_ckpt_layers:
for num_mbs_act in num_micro_batches_partial_act_ckpt:

Check warning

Code scanning / CodeQL

Unreachable code Warning

This statement is unreachable.
@prekshivyas prekshivyas mentioned this pull request Aug 22, 2025
8 tasks
@dimapihtar dimapihtar self-requested a review August 27, 2025 10:38
Copy link
Collaborator

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@github-actions
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants