Remove Unexecuted Hyena Code Paths #12856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
jstjohn
previously approved these changes
Apr 2, 2025
|
LGTM, dead code is dead! |
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
9 tasks
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: farhadrgh <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
…arhadr/evo2_clean
JRD971000
approved these changes
Apr 8, 2025
jomitchellnv
pushed a commit
to jomitchellnv/NeMo
that referenced
this pull request
Apr 8, 2025
* drop multihead_forward Signed-off-by: Farhad Ramezanghorbani <[email protected]> * drop multihead_forward Signed-off-by: Farhad Ramezanghorbani <[email protected]> * drop flashfft Signed-off-by: Farhad Ramezanghorbani <[email protected]> * drop use_long_conv1d Signed-off-by: Farhad Ramezanghorbani <[email protected]> * drop cgcg Signed-off-by: Farhad Ramezanghorbani <[email protected]> * drop custom hyena mlp/short conv kernels Signed-off-by: Farhad Ramezanghorbani <[email protected]> * drop downsampling Signed-off-by: Farhad Ramezanghorbani <[email protected]> * drop unused is_mlp path Signed-off-by: Farhad Ramezanghorbani <[email protected]> * improve make_upper_case Signed-off-by: Farhad Ramezanghorbani <[email protected]> * remove unused configs Signed-off-by: Farhad Ramezanghorbani <[email protected]> * switch to inplace Signed-off-by: Farhad Ramezanghorbani <[email protected]> * consolidate fp8 logic Signed-off-by: Farhad Ramezanghorbani <[email protected]> * doc str Signed-off-by: Farhad Ramezanghorbani <[email protected]> * rm douplicate import Signed-off-by: Farhad Ramezanghorbani <[email protected]> * fix linting issues Signed-off-by: Farhad Ramezanghorbani <[email protected]> * drop unnecessary rearrange Signed-off-by: Farhad Ramezanghorbani <[email protected]> * reduce rearrange overhead Signed-off-by: Farhad Ramezanghorbani <[email protected]> * Apply isort and black reformatting Signed-off-by: farhadrgh <[email protected]> * make flake8 happy Signed-off-by: Farhad Ramezanghorbani <[email protected]> --------- Signed-off-by: Farhad Ramezanghorbani <[email protected]> Signed-off-by: farhadrgh <[email protected]> Signed-off-by: Jonathan Mitchell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information