Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing keyword argument for rerun state machine's state dict method #12873

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

adil-a
Copy link
Collaborator

@adil-a adil-a commented Apr 3, 2025

What does this PR do ?

I think the current codebase uses an old API version of MCore's RerunStateMachine state_dict method. Changing out the way we call it with the correct kwargs.

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@adil-a adil-a added the core Changes to NeMo Core label Apr 3, 2025
@adil-a adil-a requested a review from ananthsub April 3, 2025 20:56
@github-actions github-actions bot removed the core Changes to NeMo Core label Apr 3, 2025
@adil-a adil-a merged commit 51b8167 into mlm-pretrain-loop Apr 7, 2025
27 of 30 checks passed
@adil-a adil-a deleted the tron_checkpoint_bugfix branch April 7, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants