Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NFS data cache #12879

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

add NFS data cache #12879

wants to merge 6 commits into from

Conversation

akoumpa
Copy link
Member

@akoumpa akoumpa commented Apr 4, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Adds a copy of the test_data.tar.gz under /home/TestData and uses it by default (from /home/TestData) instead of downloading from the url.

This should save CI some time and avoid flaky errors due to bad connectivity.

IDK if it's worth baking in a checksum check.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

akoumpa added 2 commits April 4, 2025 01:12
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
ko3n1g
ko3n1g previously approved these changes Apr 4, 2025
Copy link
Collaborator

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the akoumparouli/skip_test_data_download branch from 59a917f to 1cc68bf Compare April 4, 2025 08:26
@akoumpa akoumpa marked this pull request as ready for review April 4, 2025 08:27
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Apr 4, 2025
@akoumpa
Copy link
Member Author

akoumpa commented Apr 4, 2025

Added one more commit to skip an unnecessary copy

Copy link
Collaborator

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Apr 4, 2025
… during tarfile extraction

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Apr 4, 2025
@akoumpa akoumpa added Run CICD and removed Run CICD labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants