Connection test to service should retry on 429 and 503#209
Closed
tdewanNvidia wants to merge 205 commits intomainfrom
Closed
Connection test to service should retry on 429 and 503#209tdewanNvidia wants to merge 205 commits intomainfrom
tdewanNvidia wants to merge 205 commits intomainfrom
Conversation
* Upgrade pylint 2.15.3 -> 4.0.4 * Fix linter errors/warnings
* OSMO-5986: Port forward button not appearing * PR feedback * Typo
* OSMO-5625: OSMO WCAG 2.1 compliance * Fix TopMenu on 400% zoom; fix prettier * Polish drop-down arrow pos * Fix top menu font size * Create Collection as Icon button... always there, but aria-disabled if needed * Move Layout to top-level and move tutorials to their own route * Fix double-header on workflows * Fix responsiveness of gauges on pool details * Add ariaLabel to SlideOut * Fix outline for checkboxes * Add missing role=list for gauges * Disable task filters when not in list view * Switch to hamburger menu for all screen sizes. Show h1 title on all views. * Combine top menu and profile menu * Move platforms to the top of pool details * Make header and body bg slightly different * Polish columns on single wf view * Fix for single task view (don't update URL, aria-disable buttons * Polish * Pin menu * OSMO-5964: Animate the opening/closing of menu/slideout * OSMO-5980: When RHS is pinned the body gets horizontal scroll instead of just the table * Spinners * useMinScreenWidth * Fix warning about keys * OSMO-5981: Screen Reader: Table announces "No Results Found" as it is loading, and the spinner never says "Loading" * Fix Single Task View * Fix cligin graph view * PR feedback * Mpore PR feedback * Tie @tanstack/react-query to 4.32.x
… editable by helm chart (#176)
* Move data.constants into data.storage.constants * Add data.storage.credentials * Update DAL to handle credential-less operations * Support different credential strategies * Update dataset to be keyless * Fix build/linter issues for keyless data creds * Revert formatting * Update credential resolution * Linter * Switch to a cached property for resolved_data_credential * Fix lint * Interop with existing credential objects in db * Address feedback * Adjust validate_data logic * Lint * Address comments * Make workflow validate_data more intuitive * Refine resolved_data_credential * Clean up
#179) * Cannot collapse Tasks Filters as Guest user in Local Deployment * Fix lint
* Add MobilityGen workflow for synthetic data generation * Address PR review comments: fix task name and add Isaac Sim link * Simplify README: link to documentation instead of duplicating steps * Address review: add curl commands, simplify prerequisites, remove extra sections * Add Cosmos Transfer-2.5 documentation link --------- Co-authored-by: SAURAV NANDA <sauravn@nvidia.com>
* Dont include imagePullSecret if there is no imagePullSecret set * Update router and web-ui as well * Keep at version 1.0.1 for all charts
tdewanNvidia
temporarily deployed
to
internal-ci
GitHub Actions
Inactive
RyaliNvidia
reviewed
Jan 9, 2026
| url_config.url, | ||
| status_code, | ||
| ) | ||
| return None |
Contributor
There was a problem hiding this comment.
How is the behavior different between this and failure_status_codes since they both return None. How do we differentiate between the two to retry with this one but not with the one below?
ecolternv
reviewed
Jan 9, 2026
| retriable_status_codes: List[int] = pydantic.Field( | ||
| default=[429, 503], description='Status codes that should trigger retry') | ||
| failure_status_codes: List[int] = pydantic.Field( | ||
| default=[500, 501, 502, 504, 505, 506, 507, 508, 510, 511], |
Contributor
There was a problem hiding this comment.
Seems kind of odd that by default this is full of 500 status codes, but down below we have
if status_code in url_config.failure_status_codes or status_code >= 500:
This might as well default to an empty list if we always check all 500 status codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Connection test to service should retry on 429 and 503
Issue - None
Checklist