-
Notifications
You must be signed in to change notification settings - Fork 740
probes: refactor fact snippet mixin #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Leon Derczynski <[email protected]>
erickgalinkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I think it's a really good improvement on the existing logic -- thanks!
|
Don't merge til after 0.11.0, alters bag probes content slightly |
jmartin-tech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures are due to import changes from main.
|
Thanks Will work out a better pattern for configuration before merging. Maybe by also doing merge w Probe.DEFAULT_PARAMS and requiring appropriate mro in inheritance descriptions. |
requires #1181
Refactor snippet code in
latentinjectionprobes to move function up intoFactSnippetMixinvalidation:
FactSnippetMixincontain exactly oneINJECTION_MARKERFactSnippetMixintodo (may be out of scope):
DEFAULT_PARAMS