Skip from_json overflow tests for [databricks] 14.3#11719
Merged
revans2 merged 3 commits intoNVIDIA:branch-24.12from Nov 20, 2024
Merged
Skip from_json overflow tests for [databricks] 14.3#11719revans2 merged 3 commits intoNVIDIA:branch-24.12from
from_json overflow tests for [databricks] 14.3#11719revans2 merged 3 commits intoNVIDIA:branch-24.12from
Conversation
Fixes NVIDIA#11533. This commit addresses the test failures reported in NVIDIA#11533, for the following tests: - `json_matrix_test.py::test_from_json_long_structs()` - `json_matrix_test.py::test_scan_json_long_structs()` These failures are a result of NVIDIA#11711. When the JSON parser attempts to read integral struct members from a JSON file, if the parsing leads to an overflow, then the `STRUCT` column value is deemed null on Databricks 14.3 (i.e. *without* `spark-rapids` active). This behaviour differs from that exhibited by Apache Spark versions exceeding 3.4.1. This commit breaks out the problematic JSON test rows into a separate file, whose read is tested in an `xfail` for Databricks 14.3. The remaining rows are tested on all versions. The true fix for NVIDIA#11711 will be addressed later. Signed-off-by: MithunR <[email protected]>
Collaborator
Author
|
Build |
revans2
previously approved these changes
Nov 13, 2024
integration_tests/src/test/resources/int_struct_formatted_overflows.json
Show resolved
Hide resolved
Collaborator
Author
|
Build |
revans2
reviewed
Nov 14, 2024
Collaborator
Author
|
Build |
Collaborator
Author
|
The CI runs are fine. The failure in |
revans2
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11533.
This commit addresses the test failures reported in #11533, for the following tests:
json_matrix_test.py::test_from_json_long_structs()json_matrix_test.py::test_scan_json_long_structs()These failures are a result of #11711. When the JSON parser attempts to read integral struct members from a JSON file, if the parsing leads to an overflow, then the
STRUCTcolumn value is deemed null on Databricks 14.3 (i.e. withoutspark-rapidsactive). This behaviour differs from that exhibited by Apache Spark versions exceeding 3.4.1.This commit breaks out the problematic JSON test rows into a separate file, whose read is tested in an
xfailfor Databricks 14.3. The remaining rows are tested on all versions.The true fix for #11711 will be addressed later.