CMake: corrections #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

scivision wants to merge 3 commits into NVlabs:master from scivision:dev-cmake

scivision commented Nov 10, 2023

to set default build type, it must be done before project()
use simpler list(APPEND to avoid typos
use generator expressions rather than CMAKE_C_FLAGS
correct use of definitions instead of options

scivision added 3 commits

November 10, 2023 09:40


          cmake: must set build type before project()

7d4deb8

also account for env var CMAKE_BUILD_TYPE


          cmake: use list(APPEND to avoid typos

ad83198


          cmake: use options/defns rather than direct vars

cf15f46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet