Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest - tweaks following group demo #1202

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Ingest - tweaks following group demo #1202

merged 5 commits into from
Oct 16, 2024

Conversation

fvankrieken
Copy link
Contributor

Follow up to #1166. Primarily,

  • separate out default processing step logic into helper
  • clean up language "processing" vs "preprocessing" (make consistent)
  • raise not implemented for custom script
  • publish json schema

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.60%. Comparing base (90497a2) to head (67be0be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
+ Coverage   67.84%   68.60%   +0.75%     
==========================================
  Files         110      109       -1     
  Lines        5847     5771      -76     
  Branches      641      634       -7     
==========================================
- Hits         3967     3959       -8     
+ Misses       1754     1685      -69     
- Partials      126      127       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


import json
from tempfile import TemporaryDirectory
from pathlib import Path

RECIPES_BUCKET = "edm-recipes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious your rationale on adding a new bucket vs having all our schemas colocated. Just thinking that if we keep adding schemas, not sure they'll be 1-1 with buckets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree with that, it just on one level made sense to have them in the same place as all the objects that refer to them. But I'm with you - this should really just live in one place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe we move it somewhere more "neutral" but that place can be publishing for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in new commit

Copy link
Contributor

@alexrichey alexrichey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@fvankrieken fvankrieken merged commit d0294e8 into main Oct 16, 2024
20 checks passed
@fvankrieken fvankrieken deleted the fvk-ingest branch October 16, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants