Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add s2 dependencies to Dockerfile. #75

Closed
wants to merge 2 commits into from
Closed

Add s2 dependencies to Dockerfile. #75

wants to merge 2 commits into from

Conversation

rasmi
Copy link
Contributor

@rasmi rasmi commented Sep 12, 2023 •
edited
Loading

@rasmi rasmi requested a review from a team as a code owner September 12, 2023 19:46
@rasmi rasmi changed the title Add s2 dependency libudunits2-dev to Dockerfile. Add s2 dependencies to Dockerfile. Sep 12, 2023
rasmi
rasmi commented Sep 12, 2023
View reviewed changes
Dockerfile
RUN apt-get update && apt-get install -y \
libudunits2-dev \
libgdal-dev \
libgeos-dev \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically not necessary to include libgeos-dev and libproj-dev explicitly since they are installed alongside libgdal-dev, but doesn't hurt to be explicit following the sf package documentation.

@rasmi rasmi mentioned this pull request Sep 12, 2023
Merged
@rasmi
Copy link
Contributor Author

rasmi commented Sep 12, 2023

Now getting an error:

Error: package or namespace load failed for ‘sf’:
 .onLoad failed in loadNamespace() for 'sf', details:
  call: get(genname, envir = envir)
  error: object 'rename_with' not found

Seems related to loading dplyr (possibly an outdated version).

@rasmi rasmi marked this pull request as draft September 13, 2023 19:20
@TylerMatteo
Copy link
Contributor

Hi @rasmi I'm going to close this PR because your commits in #76 have landed in main with #79 . That PR also updates the code to build with PAD version 24a, which appears to be working as intended. Thanks again for the contribution!

@rasmi
Copy link
Contributor Author

rasmi commented Mar 22, 2024

Awesome, thanks Tyler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasmi @TylerMatteo