1566 Send confirmation email to new subscriber #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for labs-zap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dhochbaum-dcp
force-pushed
the
1566/confirmation-email
branch
from
0f1ec83
to
ab76675
Compare
TylerMatteo
requested changes
Nov 6, 2024
There was a problem hiding this comment.
@dhochbaum-dcp Looks pretty good overall. In addition to the two comments I left in code, I'd like you to try adding some unit tests for the methods in the subscriber service.
TylerMatteo
requested changes
Nov 7, 2024
TylerMatteo
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Send confirmation email to new subscribers when they are successfully signed up.
/subscribers/<uuid>/confirm.Tasks/Bug Numbers
Completes #1566
Email link needs to be updated once we have a URL for "Modify Subscriptions".
Code for the email is currently not in the repo, can be seen/edited here: https://mc.sendgrid.com/dynamic-templates/d-3684647ef2b242d8947b65b20497baa0/version/62d2fdea-926f-4443-970d-bf8c5f88474d/editor