896 prefer static intersecting layers #1031
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allthesignals
force-pushed
the
896-prefer-static-intersecting-layers
branch
3 times, most recently
from
f66551c
to
33c320c
Compare
…operty on lot model rather than on-the-fly spatial intersection
allthesignals
force-pushed
the
896-prefer-static-intersecting-layers
branch
from
33c320c
to
815bd5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #896 by reducing the # of dynamic intersecting layer calculations.
Instead 3 of the layers' intersections are inferred from columns directly available on the lot.
There are more available intersecting layers but they might be available on another file see: NYCPlanning/db-pluto#55