Update Selenium to avoid session creation errors #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfriedman6
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Nice (especially the README changes)! Approving but please wait to deploy until https://github.com/NYPL/overdrive-checkout-poller/pull/12 is deployed to prod and we know --headless=new doesn't break anything
|
The OD poller ran successfully in QA and prod! There might be a mismatch between the 2/19 records bc of the deployments but I will fix that tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this last weekend's errors, OverDrive on occasion throws up this error:
session not created: probably user data directory is already in use, please specify a unique value for --user-data-dir argument, or don't use --user-data-dirThe change reflects the Selenium deprecation of the headless option.