DR-3764 Display multiple languages #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
keithbauer
changed the title
sarangj
approved these changes
Aug 1, 2025
| @@ -22,7 +22,7 @@ export function normalizeItemMetadataFromManifest( | |||
| physicalDescription: joinWithBr(raw["Physical Description"]), | |||
| typeOfResource: joinWithBr(raw["Resource Type"]), | |||
| abstract: raw["Abstract"]?.[0] || "", | |||
| languages: raw["Languages"]?.[0] || "", | |||
| languages: joinWithBr(raw["Languages"]) || "", | |||
There was a problem hiding this comment.
Looks like joinWithBr always returns a string, so don't need to keep the || "" bit!
…collections into DR-3764/multiple-languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
This PR does the following:
Open questions
How has this been tested? How should a reviewer test this?
Tested locally with http://localhost:3000/items/e06d3e10-c553-012f-193f-58d385a7bc34?canvasIndex=0
Accessibility concerns or updates
Checklist: