default to eb in API route #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Toxiapo
reviewed
Jun 9, 2025
src/utils/api.ts
Outdated
Comment on lines
445
to
447
| console.log(data); | ||
| console.log(data.homeLibraryCode); | ||
| // default to e branch |
Toxiapo
reviewed
Jun 9, 2025
Toxiapo
reviewed
Jun 9, 2025
There was a problem hiding this comment.
I just have a minor question about the default value, I thought it might be better to manage it in a single place, curious what your thoughts are.
The Vercel preview link is broken, I think we should make a ticket and put it in the backlog to fix that if not already!
|
The vercel integration never worked... I forgot why but there's something that stopped us in the past from generating previews. |
EdwinGuzman
reviewed
Jun 9, 2025
EdwinGuzman
approved these changes
Jun 9, 2025
Toxiapo
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Checklist: