-
Notifications
You must be signed in to change notification settings - Fork 0
SCC-3360: Back from holds situation #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
const bannerFlag = sessionStorage.getItem("holdCompleted") | ||
if (bannerFlag === "true") { | ||
setHoldCompleted(true) | ||
sessionStorage.removeItem("holdCompleted") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that this should only appear when the user has just come from back button so it's okay to delete this key once it's "used"– the banner doesn't need to appear if the user returns to this request page from the search results, for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and same for on site hold
Ticket:
This PR does the following:
How has this been tested?
Make a hold or EDD request, then go back
Accessibility concerns or updates
Checklist: