-
Notifications
You must be signed in to change notification settings - Fork 3
Added remark-cli and pnpm lock file resolution logic #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3d9e9ac
55cea62
738038d
fe44dd6
4009c18
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
git-branch-lockfile=true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,15 @@ | |
"serve": "docusaurus serve", | ||
"write-translations": "docusaurus write-translations", | ||
"write-heading-ids": "docusaurus write-heading-ids", | ||
"typecheck": "tsc" | ||
"typecheck": "tsc", | ||
"lint": "remark --frail ." | ||
}, | ||
"remarkConfig": { | ||
"plugins": [ | ||
"remark-preset-lint-recommended", | ||
"remark-mdx", | ||
["remark-lint-list-item-indent", false] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's keep There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, We could configure remark to check for newly changed files only with our lint.yaml actions file. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remark supports auto-formatting options as described here https://github.com/remarkjs/remark-lint?tab=readme-ov-file#example-check-and-format-markdown-on-the-cli We can use
Running |
||
] | ||
}, | ||
"dependencies": { | ||
"@docusaurus/core": "^3.7.0", | ||
|
@@ -27,6 +35,11 @@ | |
"@docusaurus/module-type-aliases": "^3.7.0", | ||
"@docusaurus/tsconfig": "^3.7.0", | ||
"@docusaurus/types": "^3.7.0", | ||
"remark-cli": "^12.0.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a way to keep this consistent with the version our action uses? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. We can use
and then re-add with
This will add fixed packages to
|
||
"remark-lint-list-item-indent": "^4.0.1", | ||
"remark-mdx": "^3.1.0", | ||
"remark-preset-lint-consistent": "^6.0.1", | ||
"remark-preset-lint-recommended": "^7.0.1", | ||
"typescript": "~5.7.3" | ||
}, | ||
"browserslist": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just use https://github.com/marketplace/actions/setup-pixi ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either of them works, we can use any. Please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the action provided by the pixi devs. Fewer things for us to maintain later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good !