Skip to content

Bump snitun to 0.42.0 #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Bump snitun to 0.42.0 #814

wants to merge 7 commits into from

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Feb 28, 2025 •
edited
Loading

Waits for:

  • We need to figure out what is needed to change in this lib to get the protocol version sent to the cloud service

changelog: NabuCasa/snitun@0.40.0...0.42.0

Key highlights:

  • The protocol is now versioned and will use protocol version 0 by default if the version is not provided.
  • The queue method is now fair to all multiplexer connections which means a single connection cannot starve the other connections anymore. This most commonly presented as the WebSocket disconnecting when downloading a large file.
  • protocol version 1+: The protocol can now tell the remote to pause reading (sending incoming data) when the incoming queue is backing up which avoids the connection being dropped by preventing the incoming queue from filling up and hitting the drop condition. Note that the server side must be updated for this to be effective.

@bdraco
Bump snitun to 0.41.3
166a596 
changelog: NabuCasa/snitun@0.40.0...0.41.3

Key highlights:
- The queue method is now fair to all multiplexer connections
  which means a single connection cannot starve the other connections
  anymore. This most commonly presented as the WebSocket disconnecting
  when downloading a large file.
- The protocol can now tell the remote to pause reading (sending incoming
  data) when the incoming queue is backing up which avoids the connection
  being dropped by preventing the incoming queue from filling up and
  hitting the drop condition. Note that the server side must be updated
  for this to be effective.
@bdraco
Copy link
Contributor Author

bdraco commented Feb 28, 2025

lint is failing because async_timeout is missing as a dep and snitun 0.41.x removed usage of it

#815

@bdraco bdraco marked this pull request as draft February 28, 2025 18:11
@bdraco
Copy link
Contributor Author

bdraco commented Feb 28, 2025 •
edited
Loading

needs the race fix in NabuCasa/snitun#375 and adjustments to the max/watermarks in NabuCasa/snitun#376

bdraco
bdraco commented Mar 1, 2025
View reviewed changes
@bdraco bdraco changed the title Bump snitun to 0.41.3 Bump snitun to 0.41.4 Mar 1, 2025
@bdraco
Copy link
Contributor Author

bdraco commented Mar 1, 2025

Draft until staging testing is complete and we are happy with the max/high/low water mark numbers

bdraco
bdraco commented Mar 3, 2025
View reviewed changes
@bdraco bdraco changed the title Bump snitun to 0.41.4 Bump snitun to 0.41.7 Mar 3, 2025
@bdraco bdraco marked this pull request as ready for review March 3, 2025 03:51
@bdraco bdraco marked this pull request as draft March 12, 2025 08:25
@bdraco
Copy link
Contributor Author

bdraco commented Mar 12, 2025

We should hold off merging until we implement the protocol_version passing

@bdraco
Copy link
Contributor Author

bdraco commented Mar 12, 2025

NabuCasa/snitun#396

@bdraco bdraco changed the title Bump snitun to 0.41.7 Bump snitun to 0.42.0 Apr 12, 2025
bdraco
bdraco commented Apr 12, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdraco @balloob @victorigualada