Skip to content

Direct fix for unit test#11464

Merged
mitchute merged 1 commit intodevelopfrom
11461-SizingMethod-variable-direct-fix-for-unit-test
Mar 13, 2026
Merged

Direct fix for unit test#11464
mitchute merged 1 commit intodevelopfrom
11461-SizingMethod-variable-direct-fix-for-unit-test

Conversation

@rraustad
Copy link
Collaborator

Pull request overview

Description of the purpose of this PR

Uninitialized sizing method was causing intermittent unit test failures.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad self-assigned this Mar 13, 2026
@rraustad rraustad added the DoNotPublish Includes changes that shouldn't be reported in the changelog label Mar 13, 2026
@rraustad
Copy link
Collaborator Author

This change directly fixes the failing unit test without risking other unintended consequences.

@mitchute
Copy link
Collaborator

Thanks @rraustad. Ready to go here. Merging.

@mitchute mitchute merged commit 7e3fbb7 into develop Mar 13, 2026
12 checks passed
@mitchute mitchute deleted the 11461-SizingMethod-variable-direct-fix-for-unit-test branch March 13, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DoNotPublish Includes changes that shouldn't be reported in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unintialized SizingMethod variable on Linux 24.04 for "UnitarySystemModel_MultiSpeedDXCoolCoil_Only_NoFan"

3 participants