Unit tests for layer_combination.py #41
Open
+459
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension functions in layer_combination.py
…tionaries for testing.
…py. Also reorganizing test file to match funciton order in layer_combination.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a set of unit tests for layer_combination.py. The tests cover the geometry and PFA dimensionality detection, NaN handling in the prepare_for_combination and do_voter_veto functions, veto and modified-veto behavior, and basic end-to-end do_voter_veto flows for both 2D and 3D cases.
@castelao , I would love your thoughts on this test style. I tried to target the tests around just the most important parts of each function.