Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINNA-646] Add place popover to LIDO event fields #2649

Conversation

siiriylonen
Copy link

No description provided.

@siiriylonen siiriylonen marked this pull request as ready for review July 21, 2023 07:09
module/Finna/src/Finna/RecordDriver/SolrLido.php Outdated Show resolved Hide resolved
module/Finna/src/Finna/RecordDriver/SolrLido.php Outdated Show resolved Hide resolved
module/Finna/src/Finna/RecordDriver/SolrLido.php Outdated Show resolved Hide resolved
module/Finna/src/Finna/RecordDriver/SolrLido.php Outdated Show resolved Hide resolved
module/Finna/src/Finna/RecordDriver/SolrLido.php Outdated Show resolved Hide resolved
@siiriylonen
Copy link
Author

Saatoin nyt vähän mennä sekaisin mitä pitää loop ja mitä ei. Eli jos asetetaan vain ensimmäinen id ja idType, niin oliko nyt aivan väärin ottaa koko placeId:n foreach-loop pois? Vai pitäisi loopata, mutta otetaan kuitenkin vain ensimmäinen?

@EreMaijala EreMaijala merged commit 2bce433 into NatLibFi:dev Aug 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants