[FINNA-2131] Fix organisation info truncation #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EreMaijala
requested changes
Oct 15, 2024
| var lessBtn = buttonWrapper.querySelector('.less-btn'); | ||
| var moreBtn = buttonWrapper.querySelector('.more-btn'); | ||
| moreBtn.addEventListener('click', () => { | ||
| lessBtn.blur(); |
There was a problem hiding this comment.
Tämä tarvitsee vähän selvennystä. Missä tilanteessa lessBtn:ssa on fokus kun moreBtn:ia klikataan?
There was a problem hiding this comment.
Näyttäisi se toimivan ilmankin lessBtn.blur(), mutta tuo fokus siihen .less-btn laitetaan truncate.js. (Vai miten missä tilanteessa?)
There was a problem hiding this comment.
Se voi siis olla ihan ok, mutta tarttee selittävän kommentin.
There was a problem hiding this comment.
Saavutettavuustestit menivät läpi sekä Win / Mac puolella kaikilla selaimilla.
pasitiis
approved these changes
Oct 15, 2024
EreMaijala
requested changes
Oct 15, 2024
|
Saavutettavuustestit menivät läpi sekä Win / Mac puolella kaikilla selaimilla tuon focus setting ja tab index poiston jälkeenkin. |
EreMaijala
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.