Skip to content

ci(build-main): set main NodeJS version to 20 in workflows + set npm … #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mhenkens
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

GH Workflow is using a deprecated action (upload-artifact@v2) which is deprecated.
More details on: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

The "main" NodeJS version is 18 but we use internally NodeJS 20 to build Stark.

Issue Number: N/A

What is the new behavior?

GH Actions in all workflows are up-to-date.

The main NodeJS version is now 20 and we execute tests on NodeJS 22 also.
Finally, we now depend on the latest [email protected] instead of fixed [email protected].

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@mhenkens mhenkens requested a review from SuperITMan June 27, 2025 08:32
@mhenkens mhenkens force-pushed the bugfix/github_actions-12.0.0-beta.2 branch from bfe294a to e557605 Compare June 27, 2025 08:40
@mhenkens mhenkens force-pushed the release/12.0.0-beta.2 branch 2 times, most recently from 064f357 to e03c632 Compare June 27, 2025 09:38
@mhenkens mhenkens force-pushed the bugfix/github_actions-12.0.0-beta.2 branch from e557605 to 59c0b5f Compare June 27, 2025 09:39
@mhenkens mhenkens force-pushed the release/12.0.0-beta.2 branch from e03c632 to 4017e13 Compare June 27, 2025 09:58
…version to 10.x instead of 10.1.0 and use github actions v4
@mhenkens mhenkens force-pushed the bugfix/github_actions-12.0.0-beta.2 branch from 59c0b5f to 2c2d6df Compare June 27, 2025 10:00
Copy link

@mhenkens mhenkens merged commit 2806ad0 into NationalBankBelgium:release/12.0.0-beta.2 Jun 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants