Initial pass at using ag-grid for client side pagination #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Tested at 43K entries. Will do further testing tomorrow on live systems. |
Collaborator
Author
|
@ivakegg @lbschanno PTAL |
alerman
changed the title
jwomeara
approved these changes
Jan 13, 2022
Collaborator
jwomeara
left a comment
jwomeara
left a comment
There was a problem hiding this comment.
I'm good with this. As we talked about, it would be great to move the HTML out of our classes and use something like Thymeaf to do templating. That should already be available sine this is a spring boot (specifically, Spring MVC) application.
| import io.protostuff.Message; | ||
| import io.protostuff.Output; | ||
| import io.protostuff.Schema; | ||
| import org.apache.avro.data.Json; |
Collaborator
There was a problem hiding this comment.
Is this an unused import? I didn't load it up in my IDE but I'm not seeing this used below.
hlgp
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial pass at using ag-grid for client side pagination. Ideally, we would move the data into an ajax call but wanted to minimize changes.