Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Type Descriptions Into Classes #33

Closed
wants to merge 1 commit into from
Closed

Introduce Type Descriptions Into Classes #33

wants to merge 1 commit into from

Conversation

foster33
Copy link
Collaborator

@foster33 foster33 commented May 6, 2024

This PR adds Type descriptions into the classes themselves. These descriptions are used when populating the 'Types' field in the Data Dictionary.

If a type does not implement TypePrettyNameSupplier (the new interface that is utilized when populating the 'Types' field), then it will use the default value provided in the interface. This is why some classes do not include these changes.

Related to dw-dictionary-service PR 23

@foster33
Copy link
Collaborator Author

foster33 commented May 6, 2024

I am open to feedback as to what would be best for Type descriptions as well as which ones should use the default / what the default value should be. The default value is temporary and is 'Default' right now.

TYPES   ||  APPEARANCE IN DATA DICTIONARY
AbstractGeometryType - Abstract Geometry
BaseType - DEFAULT
DateType - Date
GeoLatType - Latitude
GeoLonType - Longitude
GeometryType - Geometry
GeoType - Geo
HexStringType - Hex String
HitTermType - DEFAULT
IpAddressType - IP Address
IpV4AddressType - IPv4 Address
LcNoDiacriticsListType - Text List
LcNoDiacriticsType - Text
LcType - Lower Case Text
ListType - List
MacAddressType - MAC Address
NoOpType - DEFAULT
NumberListType - Number List
NumberType - Number
PointType - Point
RawDateType - Raw Date
StringType - String
TrimLeadingZerosType - Trimmed Number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant