-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix major issues from sonarqube #2336
Open
cogross
wants to merge
1
commit into
integration
Choose a base branch
from
2321-fix-major-issues-sq
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cogross
commented
Apr 3, 2024
- Interrupted exceptions should be rethrown OR method should be re-interrupted (see https://cwe.mitre.org/data/definitions/391)
- Method parameters should not be used for synchronization (see MITRE, CWE-412 - Unrestricted Externally Accessible Lock | MITRE, CWE-413 - Improper Resource Locking | CERT, LCK00-J. - Use private final lock objects to synchronize classes that may interact with untrusted code)
- Synchronization should be done on instances of value-based classes (see http://localhost:9000/coding_rules?open=java%3AS1860&rule_key=java%3AS1860)
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
3 times, most recently
from
April 5, 2024 15:57
dd6a584
to
119a61e
Compare
sparkyy34
previously approved these changes
Apr 5, 2024
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
April 11, 2024 11:54
119a61e
to
815fa66
Compare
cogross
changed the title
WIP - fix major issues from sonarqube
fix major issues from sonarqube
Apr 17, 2024
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
5 times, most recently
from
April 23, 2024 10:51
282a3e6
to
b1cfb9c
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
3 times, most recently
from
May 6, 2024 10:46
6104721
to
b56572c
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
5 times, most recently
from
May 13, 2024 15:31
a20f5dc
to
55f7e84
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
2 times, most recently
from
May 17, 2024 11:52
ff4f110
to
266af42
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
May 21, 2024 17:13
266af42
to
cd16335
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
May 21, 2024 17:13
cd16335
to
8cf51c2
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
2 times, most recently
from
June 3, 2024 10:26
8b5c522
to
0d8bd4c
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
2 times, most recently
from
June 10, 2024 15:41
d10d93a
to
6d4d795
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
July 3, 2024 16:17
6d4d795
to
844ad59
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
3 times, most recently
from
July 17, 2024 16:20
fa465c9
to
69b52ff
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
2 times, most recently
from
August 1, 2024 11:45
00f3821
to
33c1585
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
2 times, most recently
from
August 12, 2024 11:12
906f6a7
to
b68ae13
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
3 times, most recently
from
August 27, 2024 10:55
b9f7060
to
9959030
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
4 times, most recently
from
September 3, 2024 15:43
0ed3c67
to
2916175
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
4 times, most recently
from
September 16, 2024 15:46
04193c5
to
b25ce74
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
3 times, most recently
from
October 2, 2024 18:39
974a325
to
ca3f7e4
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
October 7, 2024 18:01
ca3f7e4
to
b66a3a2
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
October 15, 2024 16:28
b66a3a2
to
28348d8
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
3 times, most recently
from
November 4, 2024 11:24
4d83909
to
aaa5497
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
November 6, 2024 18:48
aaa5497
to
3d5a735
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
November 14, 2024 15:30
3d5a735
to
e2beb28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.