Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize QueryOptions to only include entries for non-default value options #2420

Open
wants to merge 59 commits into
base: integration
Choose a base branch
from
Open

Optimize QueryOptions to only include entries for non-default value options #2420

Show file tree
Hide file tree
Changes from 48 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
6e0d071
Merged integration into TQO
SethSmucker Jun 10, 2024
199781a
Merged integration into TQO
SethSmucker Jun 17, 2024
bf8b43c
Update warehouse/query-core/src/main/java/datawave/query/iterator/Que…
SethSmucker Jun 17, 2024
8b8dfd5
Merged integration into TQO
SethSmucker Jun 28, 2024
ce8bd48
Formatting
SethSmucker Jul 1, 2024
1d4366a
Fixed empty string logical error
SethSmucker Jul 1, 2024
7860443
Fixed empty string logical error
SethSmucker Jul 1, 2024
e6d0edb
Create initial implementation of way to determin default values
lbschanno Jul 10, 2024
56c976b
Fix typo
lbschanno Jul 10, 2024
0998782
Temporary commit for bugfix tools
SethSmucker Jul 2, 2024
d783669
Temporary test commit for my local branch, will be discarded later
SethSmucker Jul 3, 2024
31dd04f
testing changes
SethSmucker Jul 8, 2024
1ea0d9c
Add default values to createDefaultOptions()
SethSmucker Jul 11, 2024
962cca3
Add valueTransformer type coverage in addOption()
SethSmucker Jul 11, 2024
3ef46f8
Add Object coverage in addOption()
SethSmucker Jul 11, 2024
615190e
Updated the else condition of addOption()
SethSmucker Jul 12, 2024
5cacfeb
Removed evaluateBooleanOptions() from validateOptions(), reverting it…
SethSmucker Jul 12, 2024
6d54643
Updated DQP
SethSmucker Jul 12, 2024
1ddbcbe
Finally rebased
SethSmucker Jul 12, 2024
18047f6
Fixed FieldIndexOnlyQueryITerator
SethSmucker Jul 12, 2024
3d9ca2c
Update to DefautOptions
SethSmucker Jul 15, 2024
30243d6
DISABLE_DOCUMENTS_WITHOUT_EVENTS uses the correct member variable
SethSmucker Jul 15, 2024
f3efc4f
temp changes
SethSmucker Jul 15, 2024
a419d1d
temp changes
SethSmucker Jul 15, 2024
9985b13
Reverted extra addOption()
SethSmucker Jul 16, 2024
3a65fc7
Formatting
SethSmucker Jul 17, 2024
98382dd
Merge branch 'integration' into tighter-query-options
SethSmucker Jul 17, 2024
a9b3195
defaultOptionsMap is now static and final
SethSmucker Jul 17, 2024
0fda462
Removed dead line to create AncestorQueryIterator
SethSmucker Jul 17, 2024
0ffaa3e
Merge branch 'integration' into tighter-query-options
SethSmucker Jul 17, 2024
b724f93
Removed unused imports and reverted DynamicFacetIterator
SethSmucker Jul 19, 2024
08a9ec6
Merge branch 'integration' into tighter-query-options
lbschanno Jul 30, 2024
888e749
Revert AncestorQueryIterator
SethSmucker Jul 30, 2024
976ed9d
Remove mentions of UNIQUE from QueryOptions
SethSmucker Jul 30, 2024
ab32d82
Add QueryOptions.addOption() to DefaultQueryPlanner.addOption()
SethSmucker Jul 30, 2024
77fc3bb
Fix ((true)) and ((false)) to use single ()
SethSmucker Jul 30, 2024
2a710da
Add Javadoc comments to QueryOptions to explain defaultOptions()
SethSmucker Jul 30, 2024
3d7e3f4
Formatting
SethSmucker Jul 30, 2024
58b3397
Merge branch 'integration' into tighter-query-options
SethSmucker Jul 30, 2024
283f141
chunk 1
SethSmucker Aug 8, 2024
b76d97c
chunk 2 test
SethSmucker Aug 8, 2024
c3b4fd5
chunk 3 removeOption
SethSmucker Aug 8, 2024
d3c1be0
Changes for Laura's review
SethSmucker Aug 8, 2024
edd52d7
Add DefaultQueryOptions builder
SethSmucker Aug 9, 2024
82cab6b
Current state for Laura
SethSmucker Aug 9, 2024
bc395d4
defaultValues are immutible
SethSmucker Aug 9, 2024
dc14698
Fix null issues in tests
SethSmucker Aug 12, 2024
68ab687
Merge branch 'integration' into tighter-query-options
SethSmucker Aug 12, 2024
f277de5
Remove unneeded comments
SethSmucker Aug 13, 2024
873b187
Make default option value map private
SethSmucker Aug 13, 2024
869f67f
Formatting
SethSmucker Aug 13, 2024
5f3dcf3
Add test for Collections as a value
SethSmucker Aug 13, 2024
4506db2
Merge branch 'integration' into tighter-query-options
SethSmucker Aug 13, 2024
3f2a03e
Merge branch 'integration' into tighter-query-options
SethSmucker Aug 13, 2024
7b4893a
Merge branch 'integration' into tighter-query-options
SethSmucker Aug 16, 2024
b1e1e75
Merge branch 'integration' into tighter-query-options
ivakegg Sep 4, 2024
d1dcd47
Merge branch 'integration' into tighter-query-options
SethSmucker Sep 5, 2024
5d200d5
Merge branch 'integration' into tighter-query-options
ivakegg Nov 5, 2024
bef2f3b
Merge branch 'integration' into tighter-query-options
ivakegg Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion warehouse/query-core/src/main/java/datawave/query/iterator/FieldIndexOnlyQueryIterator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public boolean validateOptions(Map<String,String> options) {
}

if (options.containsKey(QUERY_MAPPING_COMPRESS)) {
compressedMappings = Boolean.valueOf(options.get(QUERY_MAPPING_COMPRESS));
compressedMappings = Boolean.parseBoolean(options.get(QUERY_MAPPING_COMPRESS));
}

this.validateTypeMetadata(options);
Expand Down
Loading
Loading