-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offload potentially expensive query planning steps to async tasks. #2575
Merged
apmoriarty
merged 11 commits into
integration
from
feature/multi-threaded-query-planner
Nov 13, 2024
Merged
Offload potentially expensive query planning steps to async tasks. #2575
apmoriarty
merged 11 commits into
integration
from
feature/multi-threaded-query-planner
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mineralntl
reviewed
Oct 7, 2024
warehouse/query-core/src/main/java/datawave/query/index/lookup/ShardRangeStream.java
Show resolved
Hide resolved
mineralntl
reviewed
Oct 9, 2024
warehouse/query-core/src/main/java/datawave/query/planner/DefaultQueryPlanner.java
Show resolved
Hide resolved
mineralntl
reviewed
Oct 9, 2024
warehouse/query-core/src/main/java/datawave/query/planner/DefaultQueryPlanner.java
Show resolved
Hide resolved
mineralntl
previously approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than possibly condensing a few methods but that's just personal preference
warehouse/query-core/src/main/java/datawave/query/planner/DefaultQueryPlanner.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/planner/DefaultQueryPlanner.java
Outdated
Show resolved
Hide resolved
apmoriarty
requested review from
mineralntl and
FineAndDandy
and removed request for
jwomeara
November 5, 2024 15:24
avgAGB
approved these changes
Nov 6, 2024
mineralntl
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the metadata helper is supposed to cache expensive method calls, this does not always work out in a production environment. Many of these expensive calls can be executed in parallel, thus reducing the setup time for a query.