Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offload potentially expensive query planning steps to async tasks. #2575

Merged
merged 11 commits into from
Nov 13, 2024

Conversation

apmoriarty
Copy link
Collaborator

Although the metadata helper is supposed to cache expensive method calls, this does not always work out in a production environment. Many of these expensive calls can be executed in parallel, thus reducing the setup time for a query.

  • Offloaded potentially expensive method calls to async tasks.
  • updated some planner method interfaces
  • optionally log timed saved via async execution

mineralntl
mineralntl previously approved these changes Oct 9, 2024
Copy link
Collaborator

@mineralntl mineralntl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than possibly condensing a few methods but that's just personal preference

@apmoriarty apmoriarty requested review from mineralntl and FineAndDandy and removed request for jwomeara November 5, 2024 15:24
@apmoriarty apmoriarty merged commit 8b10852 into integration Nov 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants