-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed python2 and 3 compatibility issues w docker-quickstart scripts #2618
Conversation
contrib/datawave-quickstart/bin/services/datawave/ingest-examples/tvmaze-api-query.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See latest comment
Fixed the scripts within docker-quickstart that used Python,
query.sh
andtvmaze-api-query.sh
were affected and now support Python2 and Python3.ingest-tv-shows.sh
now works correctly. Added Python3 toDockerfile
Fixes #2611