Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed python2 and 3 compatibility issues w docker-quickstart scripts #2618

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

skyler-kv
Copy link
Collaborator

@skyler-kv skyler-kv commented Oct 23, 2024

Fixed the scripts within docker-quickstart that used Python, query.sh and tvmaze-api-query.sh were affected and now support Python2 and Python3. ingest-tv-shows.sh now works correctly. Added Python3 to Dockerfile

Fixes #2611

@skyler-kv skyler-kv marked this pull request as ready for review October 23, 2024 16:51
Copy link
Collaborator

@foster33 foster33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested the changes.

Copy link
Collaborator

@keith-ratcliffe keith-ratcliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@foster33 foster33 self-requested a review October 24, 2024 15:50
Copy link
Collaborator

@foster33 foster33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See latest comment

@skyler-kv skyler-kv merged commit 38d6ac3 into integration Oct 30, 2024
5 checks passed
@skyler-kv skyler-kv deleted the dockerquickstart-issue2611 branch October 30, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Quickstart scripts don't work with Docker-Quickstart
4 participants