corresponding updates for type-utils zero regex checks #2856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a regex is lossy add the eval_only node to the group of nodes created by looping through all normalizers
ivakegg
reviewed
Apr 15, 2025
| // now we need to combine these two nodes so that both are required | ||
| JexlNode combined = JexlNodeFactory.createAndNode(Arrays.asList(new JexlNode[] {normalizedNode, evalOnly})); | ||
| normalizedNodes.add(combined); | ||
| // if the normalized term is identical to the original term, it cannot be lossy |
Collaborator
There was a problem hiding this comment.
move this outside the normalizedTerms.contains check
ivakegg
reviewed
Apr 15, 2025
| failedNormalization = !fieldName.equals(Constants.ANY_FIELD); | ||
| } | ||
| } | ||
| // todo: this merits further scrutiny |
Collaborator
|
merging manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a regex is lossy add the eval_only node to the group of nodes created by looping through all normalizers
requires: NationalSecurityAgency/datawave-type-utils#41