Make /validate check for field existence in date range #3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbschanno
requested changes
Sep 19, 2025
.../query-core/src/main/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitor.java
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitor.java
Outdated
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitor.java
Outdated
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitor.java
Outdated
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitor.java
Outdated
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitor.java
Outdated
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitor.java
Outdated
Show resolved
Hide resolved
lbschanno
requested changes
Oct 7, 2025
...ry-core/src/test/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitorTest.java
Outdated
Show resolved
Hide resolved
.../ingest-core/src/test/java/datawave/ingest/mapreduce/job/reindex/ShardReindexMapperTest.java
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitor.java
Outdated
Show resolved
Hide resolved
lbschanno
requested changes
Oct 14, 2025
core/utils/metadata-utils/src/main/java/datawave/query/util/MetadataHelper.java
Outdated
Show resolved
Hide resolved
lbschanno
requested changes
Oct 20, 2025
core/utils/metadata-utils/src/main/java/datawave/query/util/MetadataHelper.java
Outdated
Show resolved
Hide resolved
core/utils/metadata-utils/src/main/java/datawave/query/util/MetadataHelper.java
Outdated
Show resolved
Hide resolved
core/utils/metadata-utils/src/main/java/datawave/query/util/MetadataHelper.java
Outdated
Show resolved
Hide resolved
core/utils/metadata-utils/src/main/java/datawave/query/util/MetadataHelper.java
Outdated
Show resolved
Hide resolved
lbschanno
requested changes
Oct 24, 2025
core/utils/metadata-utils/src/main/java/datawave/query/util/MetadataHelper.java
Outdated
Show resolved
Hide resolved
apmoriarty
reviewed
Oct 27, 2025
.../query-core/src/main/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitor.java
Outdated
Show resolved
Hide resolved
...ry-core/src/test/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitorTest.java
Outdated
Show resolved
Hide resolved
...ry-core/src/test/java/datawave/query/jexl/visitors/FieldMissingFromDateRangeVisitorTest.java
Show resolved
Hide resolved
- Simplify test setup and execution. - Update visitor to collect fields from top-level nodes in separate subsets. - Update rule to provide more information about which query subsets are considered immaterial. --------- Co-authored-by: foster33 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates FieldExistenceRule to also verify that there is data in a field for the given date range.
In the case of an OR node, ALL fields must be missing from the date range for a failure message to be returned.