Replace Object.finalize() with AutoClosable.close() #3193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbschanno
requested changes
Sep 23, 2025
Collaborator
lbschanno
left a comment
lbschanno
left a comment
There was a problem hiding this comment.
Some additional usages of Object.finalize() that I found:
datawave.core.iterators.filesystem.FileSystemCachedatawave.core.iterators.querylock.ZookeeperQueryLockdatawave.core.iterators.querylock.HdfsQueryLockdatawave.query.planner.DefaultQueryPlanner
Both ZookeeperQueryLock and HdfsQueryLock, along with CombinedQueryLock, implement QueryLock. I don't think it would be unreasonable to have QueryLock implement Autocloseable, and make the various implementations implement close().
| @Override | ||
| protected void finalize() throws Throwable { | ||
|
|
||
| protected void close() throws Throwable { |
Collaborator
There was a problem hiding this comment.
This should be scoped public to be consistent with Autocloseable.
| } | ||
|
|
||
| @Override | ||
| protected void finalize() throws Throwable { |
Collaborator
There was a problem hiding this comment.
FileIterator should probably also implement Autocloseable and call cleanup() in close().
| @Override | ||
| protected void finalize() throws Throwable { | ||
| super.finalize(); | ||
| public void close() throws IOException, InterruptedException { |
Collaborator
There was a problem hiding this comment.
This should be annotated with @Override and ShardTableQueryMetricHandler should implement Autocloseable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3186
part of #2443