Skip to content

Move binRanges to InMemoryTableOperations #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: integration
Choose a base branch
from
Open

Move binRanges to InMemoryTableOperations #3237

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c68d779
Move bin ranges to InMemoryTableOperations
SethSmucker Oct 14, 2025
fd98b6b
Merge branch 'integration' into task/binRanges
SethSmucker Oct 20, 2025
f69071c
Remove unused imports
SethSmucker Oct 20, 2025
755f1be
Formatting
SethSmucker Oct 27, 2025
99e90db
Merge branch 'integration' into task/binRanges
SethSmucker Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .../in-memory-accumulo/src/main/java/datawave/accumulo/inmemory/InMemoryTableOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
import org.apache.accumulo.core.data.Key;
import org.apache.accumulo.core.data.Mutation;
import org.apache.accumulo.core.data.Range;
import org.apache.accumulo.core.data.TableId;
import org.apache.accumulo.core.data.TabletId;
import org.apache.accumulo.core.data.Value;
import org.apache.accumulo.core.dataImpl.KeyExtent;
Expand All @@ -77,8 +78,6 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import datawave.accumulo.inmemory.impl.InMemoryTabletLocator;

public class InMemoryTableOperations extends TableOperationsHelper {
private static final Logger log = LoggerFactory.getLogger(InMemoryTableOperations.class);
private static final byte[] ZERO = {0};
Expand Down Expand Up @@ -560,11 +559,15 @@ public SamplerConfiguration getSamplerConfiguration(String tableName) throws Tab
@Override
public Locations locate(String tableName, Collection<Range> ranges) throws AccumuloException, AccumuloSecurityException, TableNotFoundException {
Map<String,Map<KeyExtent,List<Range>>> binnedRanges = new HashMap<>();
InMemoryTabletLocator locator = new InMemoryTabletLocator();
List<Range> ignore = locator.binRanges(null, new ArrayList<>(ranges), binnedRanges);
List<Range> ignore = binRanges(new ArrayList<>(ranges), binnedRanges);
return new LocationsImpl(binnedRanges);
}

private List<Range> binRanges(ArrayList<Range> ranges, Map<String,Map<KeyExtent,List<Range>>> binnedRanges) {
binnedRanges.put("", Collections.singletonMap(new KeyExtent(TableId.of(""), null, null), ranges));
return Collections.emptyList();
}

private static class LocationsImpl implements Locations {

private Map<Range,List<TabletId>> groupedByRanges;
Expand Down
Loading